style(scss): Remove outline border from button#3000
Closed
heithemmoumni wants to merge 1 commit intonodejs:masterfrom
heithemmoumni:patch-1
Closed
style(scss): Remove outline border from button#3000heithemmoumni wants to merge 1 commit intonodejs:masterfrom heithemmoumni:patch-1
heithemmoumni wants to merge 1 commit intonodejs:masterfrom
heithemmoumni:patch-1
Conversation
Member
|
I'm not seeing what this would be used for. Usually you don't want to remove outlines for accessibility reasons, but I don't see a difference in the rendering when trying this with the dev tools in Firefox |
Author
|
cool, ok |
Contributor
|
Yeah, definitely a bad practice to remove the outline unless the effect is replaced with something else. I'll try to have a look in the next days. FYI Firefox handles this differently hence why the issue is only visible on Chromium based browsers AFAICT. |
Contributor
|
Alright, I tested this and like I said above, it's bad practice to do this. |
This was referenced Nov 25, 2023
This was referenced Dec 1, 2023
This was referenced Dec 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.